fix(fetch): preserve Request __sapiom metadata - #691
Open
Kewe63 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #690
@sapiom/fetchdocuments per-request overrides by attaching__sapiommetadata directly to aRequest, including{ enabled: false }to bypass Sapiom for one request.However,
createFetch()cloned the input withnew Request(input, init)before reading metadata. NativeRequestcloning does not preserve custom properties, soRequest.__sapiomwas lost.This PR preserves the metadata before cloning and reattaches it to cloned requests so per-request overrides keep working.
Changes
__sapiommetadata from the originalRequestbefore cloning.Request.__sapiom = { enabled: false }.How to Test
corepack pnpm --filter @sapiom/fetch test corepack pnpm --filter @sapiom/fetch lint corepack pnpm --filter @sapiom/fetch typecheck corepack pnpm --filter @sapiom/fetch build git diff --checkChecklist
Request.__sapiom = { enabled: false }Risk & Impact
Low. The fix only affects how
__sapiommetadata survives internalRequestcloning — it reads and reattaches the metadata rather than changing any clone or fetch behavior. Requests without__sapiommetadata are unaffected.Type: 🐛 Bug fix
Fixes: #690